Fix get_blobs_list_async method to return BlobProperties #32545
Conversation
The get_blobs_list_async method advertised to return list of BlobProperties but returned list of blob names. This is a bug that has been detected by MyPy checks with the new Azure blob package.
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
I think as of this new version of azure-blobs, MyPy check is "good enough" for the test case :) |
Philosophical comment: this is basically the "promise" of Type Hinting + MyPY. Once we have all of our code type-hinted (in ideal world) we should be able to drop all the tests that just check if the types are correct. I consider that mostly as "unit testing aid" (as much as hinting the users and helping with auto-completion). |
|
Static check and some provider tests passed. Merging. |
|
One issue not directly related to mypy but can't help noticing that there are other similar functions like |
|
Sure. One can propose it. I looked t at it before, but I wanted to handled the issue at hand where the "advertised" behaviour was inconsistem. IMHO the advertised behaviour inconsistency is an important aspect because you tell something that is not true. The other methods don't tell the type returned (they only tell "list"). so they are not consistent, but at least they are not lying. The goal of this PR fixing a lie (which lead to worsened experience for contributors is worht it), not making things consistent. But if anyone would like to take on the task of making it consistent - this would be cool and you are welcome to do it :). |
The get_blobs_list_async method advertised to return list of BlobProperties but returned list of blob names. This is a bug that has been detected by MyPy checks with the new Azure blob package.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.